Conversation
ata_wait_ready returns a bool not an error number
Instead of IOERR_NOCMD which might make it appear to software that HD_SCSICMD is not supported we instead respond with "Invalid command opcode" sense and HFERR_BADSTATUS
…th the relevant sense data to indicate the fault
* Staple a romtag to ODFS * Add resulting file to release + adf
* SCSI ATA PASSTHROUGH: enforce word alignment of scsi_Data * TD_GETGEOMETRY: enforce word alignment of io_Data, check for NULL pointer and check io_Length * NSCMD_DEVICEQUERY: Check for NULL pointer and alignment of io_Data
Don't constantly allocate/deallocate memory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.